[Fix] Fast misses Slack follow-ups after peer mentions - #2407
[Fix] Fast misses Slack follow-ups after peer mentions#2407roomote-roomote[bot] wants to merge 5 commits into
Conversation
|
Pushed and verified fc419ff6: GitHub PR head and remote branch match that SHA. Removed The actual final diff retains the established-Fast-thread cutoff bypass in 75 focused Slack tests and 103 SDK tests pass, plus affected typechecks and pre-push gates. The reminder is ordinary model context, not guaranteed persistent state; no live-model silence claim. Earlier unrelated DB-test schema failures remain disclosed in the refreshed PR body. PR not merged. |
Related issue
Maintainer-requested refinement; no linked public issue.
Why this PR exists
Replace the human-to-human admission cutoff in established Fast Slack threads with a per-message advisory, without reconstructing or storing participation state.
What changed
agentContext. Messages explicitly directed at Roomote are not cautioned. The reminder is untrusted supplemental context, separate from authored text, asking Fast to remain quiet unless directly addressed from then on.priorMessages,latestDirectAddress,directlyAddressesRoomote,hasPeerDiscussion, the plain-name reset heuristic, and associated state tests/comments. Ordinary pre-existing history retrieval still provides thread context and attachments; it does not regenerate the reminder.The reminder remains ordinary model conversation context. It is not reattached to later messages without a peer mention and may be lost through context compaction. Model compliance is advisory, not a hard tool restriction. More admitted messages incur inference cost. Existing mention parsing cannot distinguish another app's user ID from a human without an additional lookup; none is added.
How it was tested
work_items.result_accepted_at; that broader suite was not rerun. No live-model or visual validation claimed.fc419ff6c1f5564b6d0790675979c2e84b6f39e1. Reviewed the actual base-to-head diff; removed history-state symbols are absent. PR not merged.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetThe exact full commands in the checklist were not run; affected-package typechecks and pre-push gates passed. No changeset was added.